Skip to content

chore: update ldk-node-go#2256

Merged
rolznz merged 1 commit intogetAlby:masterfrom
hermes-alby:chore/update-ldk-node-channel-limit
Apr 25, 2026
Merged

chore: update ldk-node-go#2256
rolznz merged 1 commit intogetAlby:masterfrom
hermes-alby:chore/update-ldk-node-channel-limit

Conversation

@hermes-alby
Copy link
Copy Markdown
Contributor

@hermes-alby hermes-alby commented Apr 24, 2026

Summary

Closes #2016.

Test Plan

  • GOTOOLCHAIN=go1.25.0 go mod tidy
  • GOTOOLCHAIN=go1.25.0 go test ./lnclient/ldk
  • GOTOOLCHAIN=go1.25.0 go test ./... (fails for existing setup reason: frontend/frontend.go:11:12: pattern dist: no matching files found in packages that embed the frontend dist; non-frontend-dist packages passed)

Summary by CodeRabbit

  • Chores
    • Updated Go module dependency for improved stability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

📝 Walkthrough

Walkthrough

Updated the github.com/getAlby/ldk-node-go Go module dependency from commit fbe7fe6a114d (2026-03-25) to commit 3690cdb3031c (2026-04-24) in go.mod.

Changes

Cohort / File(s) Summary
Dependency Update
go.mod
Bumped github.com/getAlby/ldk-node-go dependency to a newer commit (3690cdb3031c).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 Hop, hop—a version bump so fine,
Dependencies updated in a line,
From March to April, commits align,
LDK-node-go shines bright and divine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: update ldk-node-go' directly and clearly summarizes the main change: updating the ldk-node-go dependency from one commit to another.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK with a 21M sat incoming channel on Mutinynet

@rolznz rolznz merged commit d97ed71 into getAlby:master Apr 25, 2026
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase LDK maximum inbound channel size

2 participants