Skip to content

Key bundled install counts by canonical plugin ID - #2420

Merged
ymichael merged 1 commit into
mainfrom
bb/post-merge-fix-map-bundled-install-counts-by-plu-thr_95q8c9ncnb
Aug 25, 2026
Merged

Key bundled install counts by canonical plugin ID#2420
ymichael merged 1 commit into
mainfrom
bb/post-merge-fix-map-bundled-install-counts-by-plu-thr_95q8c9ncnb

Conversation

@ymichael

Copy link
Copy Markdown
Collaborator

What was wrong

Plugin install telemetry and the trusted marketplace stats sidecar key bundled plugins by canonical plugin ID, but the server's bundled search-result mapper joined those counts with the separate source entry name. Docs is the existing alias: its source entry is docs, while its canonical plugin ID is simple-notes, so both the web store and bb plugin search omitted its published count. The same mismatch would affect any future bundled alias. This is a focused follow-up to #2282.

What changed

The bundled mapper now reads the trusted count map with the canonical entry.pluginId. The existing server regression uses the repository's real docs / simple-notes registration, so it protects the class-wide identity invariant rather than a same-name fixture.

Curated marketplace entries remain keyed by entry.id; third-party counts remain null; lifetime-count and privacy semantics are unchanged. No alias registry, compatibility layer, migration, persisted state, public API, CLI/app code, guide/docs, or mobile change was added. Nothing crosses the server/host-daemon boundary, so HOST_DAEMON_PROTOCOL_VERSION remains 167.

How you verified

  • The regression failed before the production change with expected null to be 12, then passed after it.
  • Focused install-count group: 6 passed.
  • pnpm exec turbo run test --filter=@bb/server --force: 211 test files passed, 1 skipped; 2,030 tests passed.
  • pnpm exec turbo run typecheck --filter=@bb/server: passed.
  • pnpm exec turbo run build --filter=@bb/server: passed.
  • Current dev API returned { entryId: "docs", pluginId: "simple-notes", installs: 139 }.
  • Checkout-built bb plugin search Docs printed an Installs column with 139.
  • DevBrowser verified Extensions → Plugins renders 139 installs on the Docs card.
  • git diff --check: passed.

Fixes: none — follow-up to #2282.

AGENT GENERATED

@ymichael
ymichael merged commit 3a6853e into main Aug 25, 2026
15 checks passed
@ymichael
ymichael deleted the bb/post-merge-fix-map-bundled-install-counts-by-plu-thr_95q8c9ncnb branch August 25, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant