Fix/enrichment nan and bidirectional similarity#2
Merged
Conversation
Correctness fixes: - Return NaN for RR/OR when either comparison group is empty instead of misleading continuity-corrected effect sizes. - Match EFO similarity pairs in both orientations in matching and disease expansion (handles inline or one-sided lookup tables). New features: - Add two-sided Fisher's exact test p_value to enrichment results (statistics.fisher_exact_pvalue, exposed in API/CLI/MCP output). - Add create_matched_pairs_df() audit export with gene, ct_efo_id, ge_efo_id, similarity, and match_type columns. - Add validate(return_matched_pairs=True) and CLI --save-matched-pairs (optional output.save_matched_pairs in YAML config). - Improve CLI summary: show p-value column and render undefined RR/CI as N/A. CI: - Add GitHub Actions workflow (.github/workflows/ci.yml) running ruff and pytest on Python 3.11, 3.12, and 3.13. Tests: 130 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.