Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assume there is a conditionally shown element and the user has data for that field. If this element becomes hidden the according data gets removed so the resulting object should be the same as when the user never opened the form with that element visible.
Currently this is not working, because when the element gets hidden we set the associated field in the data to undefined. The problem is that undefined is not equal to a missing field in terms of operations like
isEqualfrom lodash.Some sample data to visualize the difference:
{ a: 10, b: 'shown' }{ a: 10, b: undefined }{ a: 10 }