fix unprediction of cog files#114
Open
daguirreg wants to merge 2 commits intogeospatial-jeff:masterfrom
Open
Conversation
Owner
|
@daguirreg This looks great, thanks for the PR! Would you mind running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this library that is being very useful to me but while using it, I found the following bug:
COG files that were compressed with prediction level 2 are being unpredicted incorrectly. The problem is that the decoder is being applied on the wrong axis.
Please find attached some images that show the problem:
This is the obtained image when applying the decoder on axis=1
Obtained image applying the decoder on axis=2
Also, take a look to the test called "test_cog_read_with_prediction_level_2" which validates the obtained image using rasterio.