feat(orchestrator): add conversation_events table, entity, and storage

[geoffjay]

Adds the persistence foundation for agent conversation history — the conversation_events SQLite table, SeaORM entity, domain types, and four CRUD methods on AgentStorage.

Changes

• Migration Remove duplicate request types in notify crate #16 (m20260417_000016_add_conversation_events.rs) — creates conversation_events table with two composite indexes (agent_id+created_at, agent_id+event_type); down() correctly drops indexes before the table
• Entity (entity/conversation_event.rs) — SeaORM Model with 7 fields matching the schema; #![allow(dead_code)] suppresses expected unused-derive warnings until Persist agent stream events in orchestrator WebSocket handler #1160 wires it up
• Domain types (types.rs) — ConversationEventType enum (8 variants, Display/FromStr), ConversationEvent struct with new() helper, ConversationQuery for filtering/pagination
• Storage methods (storage.rs) — insert_conversation_event, list_conversation_events (with type/time/pagination filters), count_conversation_events, delete_conversation_events_for_agent; plus model_to_conversation_event helper

Test plan

• 7 new unit tests in storage::tests: insert+count, list all, filter by type, limit+offset, delete (cross-agent isolation), metadata JSON roundtrip, all 8 event-type variants
• cargo test -p orchestrator — 413 tests pass (pre-existing linear_fetch_http network tests ignored)
• cargo fmt --check -p orchestrator — clean
• cargo clippy -p orchestrator — no errors

Dependencies

• Unblocks: Persist agent stream events in orchestrator WebSocket handler #1160 (WebSocket persistence), Add REST API endpoints for conversation history retrieval #1161 (REST API), Add conversation data retention policy and cleanup #1163 (retention policy)

Closes #1159

🤖 Generated with Claude Code

[geoffjay]

Review: feat(orchestrator): add conversation_events table, entity, and storage

Reviewed against the acceptance criteria in #1159. The migration, entity, domain types, and storage structure are all correct. Two issues must be fixed before merge, plus one strong recommendation.

---

🔴 Fix required — silent metadata loss in insert_conversation_event

storage.rs, insert_conversation_event:

// Current
metadata: Set(event
    .metadata
    .as_ref()
    .map(|v| serde_json::to_string(v).unwrap_or_default())),

unwrap_or_default() silently drops the metadata field if serde_json::to_string fails (e.g. a Value containing f64::NAN). The read path in model_to_conversation_event correctly propagates errors with .transpose()?. The write path should match:

// Fix
let metadata_str = event
    .metadata
    .as_ref()
    .map(serde_json::to_string)
    .transpose()
    .map_err(|e| anyhow::anyhow!("Failed to serialize event metadata: {}", e))?;

// In the ActiveModel:
metadata: Set(metadata_str),

This is consistent with anyhow-based error propagation used everywhere else in AgentStorage.

---

🔴 Fix required — since/until filter path is untested

The PR adds since and until to ConversationQuery and wires them into list_conversation_events, but no test exercises that code path. The 7 tests cover insert/count, list-all, type filtering, limit+offset, delete isolation, metadata roundtrip, and all 8 event type variants — but not time-range filtering.

Add a test:

#[tokio::test]
async fn test_conv_list_time_range() {
    let (storage, _tmp) = create_test_storage().await;
    let agent_id = Uuid::new_v4();

    storage
        .insert_conversation_event(&make_event(agent_id, ConversationEventType::Output))
        .await
        .unwrap();

    let boundary = Utc::now();

    storage
        .insert_conversation_event(&make_event(agent_id, ConversationEventType::Output))
        .await
        .unwrap();
    storage
        .insert_conversation_event(&make_event(agent_id, ConversationEventType::Output))
        .await
        .unwrap();

    // Only events after boundary
    let opts = ConversationQuery { since: Some(boundary), ..Default::default() };
    let events = storage.list_conversation_events(agent_id, &opts).await.unwrap();
    assert_eq!(events.len(), 2);

    // Only events before boundary
    let opts = ConversationQuery { until: Some(boundary), ..Default::default() };
    let events = storage.list_conversation_events(agent_id, &opts).await.unwrap();
    assert_eq!(events.len(), 1);
}

---

🟡 Recommendation — add session_number filter to ConversationQuery

The REST API (#1161) and UI (#1162) will need to replay a single session (e.g. "all events from session 3"). ConversationQuery is the right place for this and the fix is trivial while it's still a new type:

// types.rs
pub session_number: Option<i64>,

// storage.rs list_conversation_events
if let Some(sn) = opts.session_number {
    condition = condition.add(conv_entity::Column::SessionNumber.eq(sn));
}

Adding this after #1161 lands would require a ConversationQuery change that forces updates in all callers. Cheap to do now.

---

✅ What's correct

• Migration uses if_not_exists(), creates both composite indexes, and down() correctly drops indexes before the table — idempotent and reversible
• #[allow(dead_code)] on the entity file with a clear follow-up comment is the right pattern
• model_to_conversation_event uses ? throughout — correct
• test_conv_event_type_roundtrip verifies all 8 variants survive a DB round-trip — thorough
• test_conv_delete_for_agent correctly verifies cross-agent isolation
• api.rs and client.rs changes are cargo-fmt reformats only, no logic changes — acceptable
• session_number correctly typed as i64 / big_integer throughout

[geoffjay]

This change is part of the following stack:

• feat(orchestrator): add conversation_events table, entity, and storage #1167 ◀

_{Change managed by git-spice.}

[codecov]

Codecov Report

❌ Patch coverage is 89.22784% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.33%. Comparing base (116a628) to head (b04ff00).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/orchestrator/src/main.rs	0.00%	39 Missing ⚠️
...tes/orchestrator/tests/conversation_persistence.rs	94.29%	35 Missing ⚠️
crates/orchestrator/src/client.rs	0.00%	22 Missing ⚠️
crates/orchestrator/src/manager.rs	53.84%	6 Missing ⚠️
...ration/m20260417_000016_add_conversation_events.rs	89.47%	4 Missing ⚠️
crates/orchestrator/src/websocket.rs	96.62%	3 Missing ⚠️
crates/orchestrator/src/storage.rs	98.50%	2 Missing ⚠️
crates/orchestrator/src/types.rs	94.59%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
+ Coverage   58.94%   60.33%   +1.39%     
==========================================
  Files         226      228       +2     
  Lines       24467    25489    +1022     
==========================================
+ Hits        14422    15380     +958     
- Misses      10045    10109      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.