fix(release): make S3 uploads R2-compatible#5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-chunkedPutObject path that Cloudflare R2 rejectsRelease context
The first
v0.6.0tag product publish jobs failed on real S3/R2 uploads withdispatch failureat the firstPutObjecton DEB/RPM/Scoop/Homebrew surfaces. PR dry-runs passed because they do not upload immutable payloads.Cloudflare R2's S3 compatibility guidance requires disabling chunked upload behavior in other AWS SDKs. AWS SDK for Rust 1.119 defaults
PutObjectto flexible checksum calculation (WhenSupported), which enablesaws-chunkedfor streaming request bodies. SettingRequestChecksumCalculation::WhenRequiredkeeps the existing explicit path-style R2 client while avoiding that default chunked upload path.After this merges, the release tag must be recreated/moved to the merged commit before rerunning tag product publish, because tag workflows use the workflow/source at the tag commit.
Verification
cargo +nightly fmt -- --checkgit diff --checkcargo test -p xtask s3_client_calculates_request_checksums_only_when_required -- --nocapture(failed before implementation, passed after)cargo test -p xtask --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-targets --all-features