Conversation
The guidelines rail on the submit form is now a per-type pre-flight card
instead of a long document. A shared ContributionGuidelines component
renders panels for Projects, Intelligent Contract, and Milestone plus a
minimal default state: the weekly slot counter is the single visual
accent and personalizes to the user's remaining slots, the category
router can switch the type selector directly, the Milestone panel leads
with a highlighted-project eligibility check, and the post-submission
process (more information, rejection, appeal) lives in a collapsed
accordion so it appears at the right moment. On desktop the card is a
sticky right rail with internal scrolling; on mobile it collapses into a
disclosure above the form with the slot summary in its header. The
Projects contribution-type detail page reuses the same panel.
## Claude Implementation Notes
- frontend/src/components/portal/ContributionGuidelines.svelte: Rebuilt as the compact pre-flight card. Per-type panels keyed off slug (projects family / create-intelligent-contracts / milestones / general), personalized slot counter with segment bar and soft warning at 0 remaining (falls back to static copy without user data), clickable category router via the onRoute prop (plain text without it), quality bars per panel, collapsed "After you submit" accordion reset via {#key panel}, and a mobile <details> variant titled "Before you submit".
- frontend/src/lib/contributionGuidelines.js: isProjectContributionType helper centralizing legacy project slug detection.
- frontend/src/components/portal/submit-contribution/SubmitContribution.svelte: routeToType(slug) wires the router into selectType; milestoneEligible derived stays null while projects load or errored so transient failures never claim ineligibility; mobile disclosure moved above the form; desktop aside is always sticky with max-height viewport scroll (removed the project-specific non-sticky special case); isProjectType delegates to the shared helper.
- frontend/src/routes/ContributionTypeDetail.svelte: Renders the guidelines panel in detail mode (non-interactive router) on the Projects type page.
- frontend/src/tests/ContributionGuidelines.test.js: Covers the default state, all three type panels, counter personalization/warning, router callbacks, and both accordions.
- frontend/src/tests/MissionBrowsing.test.js: Detail-page guidance assertions updated to the new heading and weekly-window copy.
- frontend/CLAUDE.md: Documents the redesigned component, its panels, and props.
…on-guidelines-ui-v1 Redesign submission guidelines into a compact pre-flight check
…o-flow # Conflicts: # frontend/src/components/portal/submit-contribution/SubmitContribution.svelte
…nfo-flow Add stored submission resubmission flows
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.