Conversation
* Serve campaign vanity links directly from the backend The backend now answers the public /join/<role>/<alias> contract itself, in addition to the internal /campaigns/redirect path. Production hosting is CloudFront + S3 rather than Amplify, so the CDN only needs a plain /join/* pass-through behavior pointing at the backend origin, with no edge URL rewriting. The Amplify rule (used only by Amplify-hosted environments) now targets the live backend domain instead of the retired Lightsail host. ## Claude Implementation Notes - backend/tally/urls.py: top-level re_path serving /join/<role>/<alias> via campaigns.views.campaign_redirect (name campaign_join); /campaigns/redirect/... unchanged - backend/campaigns/tests/test_resolver.py: /join path resolves with correct utm_id and 404s unknown aliases - amplify.yml: /join/<*> target updated to https://portal-admin.genlayer.foundation/join/<*> (old Lightsail host is dead); comment documents the CloudFront equivalent for production - backend/CLAUDE.md: resolver docs reflect the direct /join route and the CloudFront + S3 production setup * Complete the public join-route contract in docs and tests The public /join redirect test now asserts the full contract (302 with Cache-Control no-store for both GET and HEAD, optional trailing slash, unknown alias 404), and the backend docs describe the exact CloudFront pass-through configuration and list the /join endpoint instead of the obsolete Amplify-proxy claim. ## Claude Implementation Notes - backend/campaigns/tests/test_resolver.py: join-path test asserts no-store on GET and HEAD, trailing slash, and 404 - backend/CLAUDE.md: endpoint summary lists GET /join/{role}/{alias} with the CDN pass-through note; campaigns section names the CloudFront methods (GET/HEAD), CachingDisabled cache policy, and AllViewerExceptHostHeader origin request policy
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend now answers the public /join// contract itself, in addition to the internal /campaigns/redirect path. Production hosting is CloudFront + S3 rather than Amplify, so the CDN only needs a plain /join/* pass-through behavior pointing at the backend origin, with no edge URL rewriting. The Amplify rule (used only by Amplify-hosted environments) now targets the live backend domain instead of the retired Lightsail host.
Claude Implementation Notes
The public /join redirect test now asserts the full contract (302 with Cache-Control no-store for both GET and HEAD, optional trailing slash, unknown alias 404), and the backend docs describe the exact CloudFront pass-through configuration and list the /join endpoint instead of the obsolete Amplify-proxy claim.
Claude Implementation Notes