Conversation
On phones the first swipe on the Overview often froze until the user tapped again or waited a moment. The content wrapper's overflow-x: hidden forced its computed overflow-y to auto, creating a nested scroll container with 132px of hidden decorative overflow that captured the first touch gesture instead of letting the page scroller move. Both overview wrappers now use overflow clip, which clips bleed without creating a scrollable box, and the documented overflow gotcha now covers this scroll-trap symptom. ## Claude Implementation Notes - frontend/src/routes/Overview.svelte: Changed the mobile wrapper class from overflow-x-hidden to overflow-x-clip and .overview-view from overflow: hidden to overflow: clip; added comments explaining the scroll-container trap and the path-section coin bleed that made it scrollable. - frontend/CLAUDE.md: Extended the overflow-x: hidden gotcha entry with the mobile touch scroll-trap symptom alongside the existing dropdown-clipping one.
The external-link and refresh icons on social task cards hugged the primary Verify or Open action on narrow screens, reading as one combined button. The trailing action cluster now keeps its right anchor on mobile, matching the desktop layout across journey steps, task grids, and task sliders. ## Claude Implementation Notes - frontend/src/components/social-tasks/SocialTaskCard.svelte: Removed the margin-left: 0 override from the max-width 420px media query so the ml-auto action cluster stays right-anchored; the wrap behavior and min-width: 0 stay in place.
…-overview-scroll-lock Fix mobile Overview scroll lock and social task icon alignment
The contribution state trends on the Metrics page now show how many submissions were actually in the pending, accepted, and more-info states over time. The daily-metrics endpoint computes point-in-time state totals per period from all submissions, instead of deriving them from submitted-in-range arithmetic, and the pending-review total is now the real backlog at the end of the selected range. Applying the daily grouping over a range wider than the endpoint allows no longer errors: the start date is automatically adapted to the widest range that fits while keeping the end date. The contribution type filter also lists non-submittable types so historical data for them can be inspected. ## Claude Implementation Notes - backend/contributions/views.py: daily_metrics adds two all-time grouped queries (creations by created_at, resolutions by reviewed_at + current state; every non-pending state sets reviewed_at, cancel included) and accumulates running pending_total/accepted_total/more_info_total per period, seeded with pre-range history. totals.pending_review is now the last period's pending_total instead of created-in-range pending count. Docstring updated. - backend/contributions/tests/test_canceled_submissions.py: new test proving state totals reflect state during the range (pre-range pending and accepted submissions count in the state series while in-range ingress/accepted event counts stay 0). - frontend/src/routes/Metrics.svelte: clampStartDateToGroupRange() mirrors the backend max range per grouping (day 366, week/month 5y/10y) and clamps the start date on Apply; empty start with daily grouping is filled with end-366 to avoid the auto-detect 400. Trend chart reads pending_total/accepted_total/more_info_total directly. Removed the two is_submittable filters so all contribution types appear in the type dropdown.
…s-daily-filter Fix Metrics state trends, daily range errors, and type filtering
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.