Skip to content

Week 5 — AlertDesk Observability and Benchmarks - #11

Open
vanna-cloud wants to merge 3 commits into
genkeydev:interns/Evelyn-Baninfrom
vanna-cloud:week-5-submission
Open

vanna-cloud wants to merge 3 commits into
genkeydev:interns/Evelyn-Baninfrom
vanna-cloud:week-5-submission

Conversation

@vanna-cloud

Copy link
Copy Markdown

Completed the Week 5 AlertDesk observability and benchmarking work.

This PR includes:

  • Request logging and observability middleware
  • Logging configuration
  • AlertDesk performance benchmark tooling
  • Benchmark documentation

@skodie-genkey skodie-genkey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

The logging and the benchmark script meet Week 5. RequestLoggingMiddleware logs method, path, status, and duration as JSON and leaves out headers, tokens, query strings, and bodies. scripts/benchmark.py warms up, then reports mean, median, p95, min, and max for create and list. It refuses a non-2xx response, and the writeup correctly says list latency grows because the endpoint returns every ticket.

docs/BENCHMARKS.md never records a run. Paste one real JSON summary: command, date, iteration count, and the create/list numbers.

Comment thread alertdesk/docs/BENCHMARKS.md Outdated

## Baseline

No latency target is specified in the client brief. Capture a baseline on the

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Week 5 asks for the baseline to be recorded here. Paste one real run: the command, date, iteration count, database size, and the emitted create/list JSON summary.

@vanna-cloud

Copy link
Copy Markdown
Author

I've updated BENCHMARKS.md with actual benchmark results from two recorded runs (October 28 and November 3, 2026). The documentation now includes the commands, dates, iteration counts, database size, and emitted JSON summaries for ticket creation and listing.

The latest update is in commit 53c4e17. Please review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants