[FEATURE] Adds category group#213
Open
rrahn wants to merge 1 commit intogenericworkflownodes:developfrom
Open
Conversation
Allows external configuration systems to boostrap plugins from different providers into a core plugin for distribution.
Contributor
Author
|
@jpfeuffer @AlexanderFillbrunn can you point me to the tests, so I can add one for the feature. And to give you a scenario. I want to be able to ship in one plugin version sources from multiple vendors. To show that some of the tools are SeqAn and others from external vendors I can add this on a configuration level and highlight it visually. |
Collaborator
|
Makes sense. But maybe the default should be for getCategoryGroup to return null, so people do not have to implement it explicitly and only overwrite it if necessary. I am afraid we don't have any tests for this yet, unless @jpfeuffer wrote some. |
Contributor
Author
|
It makes sense to make it not abstract. I'll change this. |
Member
|
There are some rudimentary tests in the com.gkn. ... . test package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows external configuration systems to boostrap plugins from different
providers into a core plugin for distribution.