Skip to content

Add advanced control and block-for-target-time render options - #13

Open
2opremio wants to merge 1 commit into
gen2brain:mainfrom
2opremio:render-options
Open

2opremio wants to merge 1 commit into
gen2brain:mainfrom
2opremio:render-options

Conversation

@2opremio

Copy link
Copy Markdown

This adds WithAdvancedControl() to NewRenderContextSW and NewRenderContextGL, and WithBlockForTargetTime(bool) to RenderSW and RenderGL, in both builds. The options are variadic, so existing calls compile unchanged, and the defaults match libmpv's. WithAdvancedControl documents the promise render.h asks for: set the update callback right after creation and never wait for the core from the render thread.

A new test renders through the software backend with both options on. I vetted and compiled the purego build, but couldn't run its tests on macOS: MacPorts' libmpv fails to dlopen there, on unmodified main too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant