Integration earn appraoch, unify stake+yield#928
Conversation
|
Review changes with Changed Files
|
Summary of ChangesHello @gemdev111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant architectural refactoring to unify the concepts of staking and yielding into a cohesive 'earn' system. It introduces a set of new, more generic data structures, such as Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-structured refactoring to unify staking and yielding functionalities under a common 'earn' abstraction. New types like EarnPosition, EarnPositionBase, and EarnProvider are introduced, and existing Delegation types are deprecated and mapped to these new structures using From implementations. The changes are consistently applied across the primitives, yielder, and gemstone crates. The new structure is cleaner and improves separation of concerns. I have one minor suggestion for code clarity.
| rewards: BigUint::ZERO, | ||
| unlock_date: None, | ||
| position_id: format!("{}-{}", self.provider(), request.asset_id), | ||
| provider_id: self.provider().to_string(), |
There was a problem hiding this comment.
To improve clarity and avoid calling self.provider() twice (once on line 120 inside format! and again here), you could store its string representation in a variable before this block.
For example:
let provider_id = self.provider().to_string();
Ok(EarnPositionBase {
// ... other fields
position_id: format!("{}-{}", provider_id, request.asset_id),
provider_id,
})
| AwaitingWithdrawal, | ||
| } | ||
|
|
||
| impl From<DelegationState> for EarnPositionState { |
There was a problem hiding this comment.
why do you need two states? if they are the same
2 participants
Stake, mappers in progress. deprecation mark for now