Repository navigation
feat: add go-to-definition, document symbols, and reference completions for CDL v1.3 - #1
Merged
Merged
Conversation
…ns for CDL v1.3 LSP support for CDL v1.3 named references. Go-to-definition for $name references, document symbols for @name definitions, completion suggestions after $, formatting for definition lines. 40 new tests (225 total).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$namereferences (jumps to@namedefinition)@namedefinitions (visible in outline/breadcrumbs)$prefix (lists all defined names)@name = ...)Files changed
src/cdl_lsp/constants.py- new constantssrc/cdl_lsp/features/__init__.py- register new featuressrc/cdl_lsp/features/completion.py-REFERENCEcontext,$completionssrc/cdl_lsp/features/definition.py- go-to-definition for$refssrc/cdl_lsp/features/diagnostics.py- definition/reference diagnosticssrc/cdl_lsp/features/document_symbols.py-@defsymbolssrc/cdl_lsp/features/formatting.py- definition line formattingsrc/cdl_lsp/server.py- register new handlerstests/test_definitions_and_references.py- 40 new testsDependencies
gemmology-cdl-parser >= 1.3.0(PR: gemmology-dev/cdl-parser#)Test plan
pytestpasses all 225 tests$nameto@namedeclaration@namedefinitions$triggers completion with defined names$referencesand unused@definitions