feat(pi-agent-team): separate team and round lifecycle - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teamId) from per-objective round execution (roundId/roundIndex).Evaluation-first
The lifecycle evaluation specification was frozen before implementation. Production code and lifecycle tests were then implemented separately and cross-validated against the frozen acceptance suite, including cancellation races, continuation session stability, bounded history, privacy, wait transitions, and foreground observability.
Before / after
Before: one run identity and status surface conflated the retained team with its latest objective execution; cancellation left continuation semantics ambiguous; rounds had no first-class identity or bounded history.
After:
teamIdis a stable retained handle, each objective is an explicit RoundRun with a uniqueroundIdand monotonicroundIndex, team lifecycle is distinct from round status/outcome, cancellation returns the team toavailable, and continuation reuses the same member sessions.Verification
npm test --workspace @geminixiang/pi-agent-team: 149/149 passednpm run check --workspace @geminixiang/pi-agent-team: TypeScript passedScope boundaries
This change intentionally does not include: