feat(sheets): add sheets.appendRow write tool#342
feat(sheets): add sheets.appendRow write tool#342rohanaceres wants to merge 4 commits intogemini-cli-extensions:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces a new appendRow tool for Google Sheets, enabling the addition of multiple rows to a spreadsheet. The implementation includes the core service logic, tool registration with Zod validation, and unit tests. Review feedback suggests renaming the tool and its associated methods to appendRows to accurately reflect its multi-row capability and recommends broadening the input schema and TypeScript types to support numbers, booleans, and null values in addition to strings.
Implements the ability to append rows to a Google Sheets spreadsheet via the MCP sheets.appendRow tool. The tool is gated behind the sheets write feature group (disabled by default, scoped to spreadsheets OAuth scope).
f1ea1b6 to
7ecb606
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Incorporates review feedback: plural name better reflects that multiple rows can be appended at once, and values now accepts numbers, booleans, and nulls in addition to strings.
Summary
sheets.appendRowMCP tool to append rows to a Google Sheets spreadsheetdefaultEnabled: false, requiresspreadsheetsOAuth scope)USER_ENTEREDvalue input option so formulas and dates are parsed correctlyTest Plan
SheetsService.test.ts)npm run test && npm run lintto verify all checks passupdatedRange,updatedRows,updatedColumns,updatedCellsIssue #341