Repository navigation
refactor: name methods and variables for what they do - #42
Merged
Merged
Conversation
validate copied nested binaries to the extension_dir root. A validator that mutates misleads; repair names what happens.
Matches the DEFAULT_ prefix family set by DEFAULT_HTTP_URL.
mock_, make_ and create_ all meant the same thing.
Nothing runs before the call. The method builds every enqueued gem serially, then pushes; the old name promised a wait on prior work.
handlers.js already calls the same customMetadata object metadata.
One-line wrapper around mark_build_complete under a negated name.
It is the gem that fetch may still return after the delete, not a path belonging to the trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the plugin, several names said one thing while the code did another. The step that puts compiled binaries back where Ruby can find them was named as if it only checked them. The step that builds and uploads every gem queued during install was named as if it only waited for work already running. A yes-or-no checksum comparison was named like a command, and the same value carried different names in neighbouring files. Each one cost a reader a detour into the body to learn what the call actually did.
Every name now says what the code does, and nothing behaves differently.