Repository navigation
fix: publish only gems compiled with default options - #39
Merged
Merged
Conversation
A publisher with PREBAKE_PUSH_ENABLED=true uploaded every gem it compiled, including gems built with options from `bundle config build.<gem>`. Everyone else on the same platform then received that build as the default build of the gem. RubyGems records the build args of an installed gem, and `spec.build_args` reads them back. A gem with recorded build args is no longer pushed, which mirrors the consumer side: such a gem already skips the cache and builds from source. Bundler records no build args for git and path gems, so build options on those gems still go unseen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
On a self-hosted setup with publishing turned on, a machine that compiled a gem with its own build options, for example pg pointed at a specific PostgreSQL install, uploaded that build to the shared cache. Everyone else on the same platform then installed it as the standard copy of the gem, although it was compiled for one machine's setup and nothing told them so.
Gems compiled with build options are no longer uploaded, so the shared cache only holds builds made with default options.