Repository navigation
style: clear outstanding rubocop offences and lint in CI - #31
Closed
Thejus-Paul wants to merge 2 commits into
Closed
Thejus-Paul wants to merge 2 commits into
Thejus-Paul wants to merge 2 commits into
Conversation
Three kinds of change, none of which alter behaviour. Most were autocorrections: semicolons, argument alignment, redundant returns, File.size(x).zero? to File.empty?, and similar. One overlong warning string is now split across two lines. Two methods were genuinely doing several jobs at once, and extracting the named steps out of them brought both back under the metrics thresholds on their own: collecting and copying installed binaries in the platform gem builder, and the path normalisation and safety guard in the extractor. The remaining offences were answered without changing code. Class length is now excluded for tests, matching how method length and ABC size are already excluded there, and the cache cascade in the extension builder patch carries a disable comment explaining why splitting it would be worse than leaving it long.
Member
Author
|
Replaced by #32. GitHub closed this automatically when the branch it was stacked on was deleted on merge; the same commits now target main there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue; this is follow-up cleanup to #29, which is why it is stacked on that branch rather than on main. It will retarget to main once #29 merges.
The linter was configured but nothing ran it, and the tree had drifted to twenty five complaints. Most were formatting the linter can fix by itself. A few were warnings that two methods had grown large enough to be doing several jobs at once. Because nobody saw any of it, the count could only go up.
Everything the linter can fix is fixed, and the two overgrown methods have had their distinct steps pulled out into named ones, which brought them back under the limits without loosening any. Two complaints were answered by settings instead: test classes are no longer held to the production length limit, and one method that is long for a good reason now records that reason. The linter runs in CI from now on, so the count starts from zero and stays there.