Add missing equations and unit tests for Thingbaijam2017#11496
Merged
Conversation
CB-quakemodel
approved these changes
May 27, 2026
Contributor
CB-quakemodel
left a comment
CB-quakemodel
left a comment
There was a problem hiding this comment.
Thanks @kurannn, LGTM. Please update the changelog with a comment to explain the new MSRs added here to the existing thingbaijam2017.py
The changelog file to update can be found in oq-engine/debian/changelog
Small typo is fixed in line 107.
micheles
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing equations in Thingbaijam2017 and its tests. Plus, information in the docstrings has been harmonized.
ThingbaijamInterface
ThingbaijamStrikeSlip
ThingbaijamNormalFault
ThingbaijamReverseFault