Repository navigation
Conversation
The report linked only the ClinVar hits, the secondary findings and the mitochondrial variants to the genome viewer, as one line of links under each table. Every findings table now ends with a Viewer column, one link per row to that row's position: ClinVar hits, secondary findings, mito variants, deep intronic sites, the cDNA scan, AnnotSV class 4-5 and the calls moved to class 3, slivar's pairs in trans and mosaic alterations. A column of its own keeps every other cell's text as it was. Bead: pgp-awpe
The genome viewer ran only on 127.0.0.1 of the machine holding the data. bin/owngenome_live_viewer.py serves the same igv.js page for every run of the live site, behind its password, and points the served report's Viewer links at it. The igv.js pin moves to versions.env so both launchers share it. tests/test_live_viewer.py checks the login, the policy, the byte ranges, the refused files, the report links, the access log and the page in headless Chrome; tests/test_viewer.py checks every findings table and reads the pin from versions.env. Bead: pgp-5bja.8 Bead: pgp-awpe
…ps tracks with an index out of GENOME_DIR and serves quoted names The live viewer compared the still-quoted request name with the file name, so a reference named with a space, '#' or '?' answered 404. It now unquotes it. An index symlinked out of GENOME_DIR was served; now its track, file and index are left out. Each new check has a planted mistake that must fail it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeiserX#296