Replaces hypotenuses length calculation by hypot() call#195
Open
denizzzka wants to merge 5 commits intogecko0307:masterfrom
Open
Replaces hypotenuses length calculation by hypot() call#195denizzzka wants to merge 5 commits intogecko0307:masterfrom
denizzzka wants to merge 5 commits intogecko0307:masterfrom
Conversation
denizzzka
commented
Nov 29, 2025
Owner
|
Tested this with some Dagon demos, and at least basic logics in the engine didn't break. Right now I'm not sure yet how justified such a change is. Performance-wise, it needs proper benchmarking, ideally against different implementations of |
Contributor
Author
Someone on internet write that the SIMD version of hypot() works 2-8 times faster than naive implementation, especially for three-argument |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hypotenuse calculation is used in many places in the code and can be sped up (but not right now, see: dlang/phobos#10906)
I made it into separate commits to make it easier to check and roll back if I screwed up somewhere