Be 23 browser notifications - #94
Merged
Merged
Conversation
…ur thread and threads you've responded in, in addition to just new questions
Collaborator
|
Profs get notifications when TAs ask Q, intentional (either could be defendable just document it in the PR or issue)? Does a TA get a notification when another TA posts a question and a student responds? |
Collaborator
Author
|
A person's role in their room has no impact on the behaviour of notifications. So yea that's intentional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser notifications will run on the following rules:
Beeps and notifications always run together. There are 3 settings:
The beep itself is not very aggressive. It's like a sinewave
Closes #95