fix: bijective Z7 aperture-7 index + R CMD check green - #54
Open
gcol33 wants to merge 4 commits into
Open
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
kAp7RotDeg was mislabeled as atan(sqrt(3/7)) (~33.2 deg) and its numeric literal drifted from the true value starting at the 12th significant digit (~233,577 ULPs), introduced in the initial commit and never caught. The correct closed form is atan(sqrt(3)/5), matching the already-correct kCos19/kSin19 constants a few lines below it in grid_math.h. Cross-checked against DGGRID's M_AP7_ROT_DEGS in DgConstants.h, which matches to all digits given (expressed there as asin(sqrt(3/28)), an equivalent closed form for the same angle). coordinate_transforms.cpp carried its own duplicate literal of the wrong value; it now derives kAp7RotRad from constants.h's kAp7RotDeg instead. Reported by Christian Carey. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cmiqcjs9Ev27KLkdgHmPkV
Previous commit accidentally wrote CRLF line endings into these three files, inconsistent with the rest of the repo, which inflated the diff to a full-file rewrite. No content change beyond line endings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cmiqcjs9Ev27KLkdgHmPkV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the aperture-7 Z7 index bijective (every cell round-trips, pure integer arithmetic) and updates the Z7 tests/cache fixture to match, fixing the R CMD check test failures on
main(currently red at 6c040c5).Verifies the fix on the full CI matrix (Linux devel/release/oldrel, macOS, Windows) before merging.
Refs #53.