Feat/0 2 pwa installability - #26
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces comprehensive PWA (Progressive Web App) capabilities, automated performance monitoring, and significantly expands test coverage for the Gluko carb calculator application. The changes transform the app into a fully installable, offline-capable PWA with enforced performance budgets.
Key changes:
- Complete PWA manifest and service worker configuration with offline-first caching strategies
- Automated Lighthouse CI workflow with performance/accessibility budgets
- Comprehensive test suites for nutrient file and meal stores (339 and 288 test cases respectively)
Reviewed changes
Copilot reviewed 13 out of 27 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
public/manifest.json |
PWA manifest defining app metadata, icons, theme colors, and display mode for installation |
index.html |
Added manifest link, theme color meta tag, and app description for PWA support |
vite.config.ts |
Enhanced service worker config with runtime caching strategies for API, images, and fonts |
vitest.config.ts |
Enabled code coverage with 80% thresholds and targeted inclusion of stores/composables |
e2e/installation.spec.ts |
E2E tests verifying PWA manifest, service worker, offline support, and installability |
src/stores/__tests__/nutrientsFile.spec.ts |
Complete unit test suite for nutrient file store with 339 lines of test coverage |
src/stores/__tests__/meal.spec.ts |
Complete unit test suite for meal store covering session management and carb calculations |
.github/workflows/lighthouse.yml |
CI workflow running Lighthouse audits with budget enforcement on every push/PR |
lighthouse-budget.json |
Performance budgets for resource sizes and core web vitals metrics |
docs/releases/v0.5-ui-polish.md |
Expanded history view requirements with edit/delete/filter capabilities |
docs/releases/v0.x-complete-redesign-proposal.md |
Comprehensive redesign proposal document exploring future UI/UX overhaul options |
package.json |
Version bump to 0.2.0 reflecting PWA feature addition |
public/icons/site.webmanifest |
Additional manifest file for icon metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces Progressive Web App (PWA) support, automated Lighthouse performance and accessibility checks, and expands both UI requirements and test coverage. The most important changes include adding a PWA manifest and meta tags, implementing end-to-end tests for PWA features, setting up a Lighthouse CI workflow with performance budgets, and enhancing the UI polish checklist and unit tests for meal management.
PWA Support and Metadata
public/manifest.json) with app details, icons (including maskable), theme and background colors, and offline-first configuration.index.htmlto reference the manifest, set the theme color, and provide a descriptive meta tag for the app.Automated Testing and Quality Assurance
e2e/installation.spec.tsto verify PWA manifest, meta tags, icon accessibility, service worker registration, offline support, installability, and mobile viewport friendliness.src/stores/__tests__/meal.spec.ts), covering session, nutrient, carb calculation, and error handling logic.Performance and Accessibility Monitoring
.github/workflows/lighthouse.yml) to run Lighthouse CI on pushes and pull requests, uploading results as artifacts.lighthouse-budget.json) to enforce limits on resource sizes and key performance metrics like FCP, LCP, CLS, and TBT.UI Requirements and Versioning
package.jsonto0.2.0reflecting these major improvements.