Conversation
juliayun23
requested changes
Jun 12, 2024
juliayun23
left a comment
juliayun23
left a comment
Contributor
There was a problem hiding this comment.
Nice work!
I'd like to suggest two small changes:
- There are still links pointing to staging sites. Might be a good opportunities to do a find&replace within this repository to make sure that there are all removed/updated.
- From a consistent format point of view, can you make sure the names of the notebooks all follow the same format? For example use the format:
number-Camel_Case.ipynb(e.g.02-Extracting_Spatial_Data_GBR_Features.ipynb).
| "\n", | ||
| "We first connect to the metadata API by retrieving the root catalog\n", | ||
| "\n", | ||
| "To do this, you will need to go to https://dashboard.staging.reefdata.io/ and copy your Authentication token.\n", |
Contributor
There was a problem hiding this comment.
This link is outdated: https://dashboard.staging.reefdata.io/
diodon
marked this pull request as draft
June 13, 2024 00:17
diodon
marked this pull request as ready for review
June 13, 2024 00:26
Contributor
@diodon Could you address the second point too? |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python notebook testing and cleaning. README added