gazctl shards prune: treat missing delete permission as non-fatal - #488
Merged
Conversation
Recovery-log pruning is best-effort cleanup of superseded fragments. When a tenant brings their own storage bucket without granting delete permission, every prune fails with AccessDenied on the recovery/ prefix. This hard-errors the command (exit 1) and fires recurring alerts for a bucket we can't clean up and don't otherwise depend on. Classify a failed fragment removal: authorization failures (missing delete permission, 403, bucket-not-found) are now logged and counted in a new non-fatal permissionDenied metric, so the prune still completes successfully. All other removal errors retain the existing failedToRemove behavior and continue to fail the command, so genuine problems keep surfacing. This reuses the per-backend IsAuthError classification already used by fragment.Persist for graceful shutdown, exposed via a new fragment.IsAuthError helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery-log pruning is best-effort cleanup of superseded fragments. When a tenant brings their own storage bucket without granting delete permission, every prune fails with AccessDenied on the recovery/ prefix. This hard-errors the command (exit 1) and fires recurring alerts for a bucket we can't clean up and don't otherwise depend on.
Classify a failed fragment removal: authorization failures (missing delete permission, 403, bucket-not-found) are now logged and counted in a new non-fatal permissionDenied metric, so the prune still completes successfully. All other removal errors retain the existing failedToRemove behavior and continue to fail the command, so genuine problems keep surfacing.
This reuses the per-backend IsAuthError classification already used by fragment.Persist for graceful shutdown, exposed via a new fragment.IsAuthError helper.