fix: harden repo hygiene and CI plumbing#5
Merged
Conversation
- generate_diagrams.py: replace hardcoded absolute Windows path with Path(__file__)-relative target so any contributor can run it - rules/29-agentic-ai-governance.md: repair UTF-8 mojibake on related- standards table (replacement chars rendered as broken boxes on GitHub) - .gitignore: add .specs/, Python cache, venv, and OS artefacts; prevents accidental commit of generated client architecture docs - .github/workflows/archpilot-lint.yml: replace non-existent gauravs19/archpilot-reviewer@v1 action (was silently never running from wrong workflows/ directory) with a real Python + archpilot lint step that gates PRs touching .specs/ or rules/ - workflows/archpilot-review.yml: deleted (wrong directory, broken action, wrong API key ref — superseded by .github/workflows/archpilot-lint.yml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_diagrams.py: hardcoded absolute Windows path (d:\_elfor\...) replaced withPath(__file__)-relative path — any contributor can now run this tool without editing sourcerules/29-agentic-ai-governance.md: repaired UTF-8 mojibake on the related-standards table (replacement characters rendered as broken boxes on GitHub).gitignore: new file — covers.specs/(generated client architecture docs), Python cache/venv, and OS artefacts.github/workflows/archpilot-lint.yml: replaces the brokengauravs19/archpilot-reviewer@v1action (referenced a non-existent published Action, was in the wrong directory so it never ran, and usedopenai_api_keyinstead of Anthropic) with a real Python +archpilot lintstep that gates PRs touching.specs/orrules/workflows/archpilot-review.yml: deleted — superseded by the aboveTest plan
python tools/generate_diagrams.pyruns without path errors from any working directoryArchpilot Lintworkflow registered.specs/*.mdrules/29-agentic-ai-governance.mdon GitHub