Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
0w3n-d
added this pull request to stack #504
September 24, 2026 14:38
Collaborator
Author
|
Superseded by #635, which puts the unreviewed Gloas stack into one PR rebased onto develop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: none. The bug came from a devnet report. Stacked on #587.
What this PR does
In Gloas, one
(slot, parent_hash)can have two beacon roots. If N-1 is missed, the root is from N-2. If N-1 is empty, the root is from N-1. The relay kept only the first payload-attributes event. It then simulated and bid with the wrong root. Now the payload attributes and the bid sorter forks use aForkKeykey, which is(parent_hash, parent_root). A submission gets the fork that has the sameprev_randao.What this PR deliberately does not do
parent_beacon_block_rootto the submission. That is a change to the signedBidTrace, so it needs agreement with builders.prev_randao, so the relay can select the wrong root.schedule.rs, keyed on(slot, parent_hash)).get_headergets the fork from the parent hash only. Before Gloas, one parent hash has only one root.Tests
prev_randao.get_execution_payload_bidliveness passes for each of the two roots on one parent hash.I wrote the tests after the implementation.
Reviewer checklist
lint,unit-test) is green🤖 Generated with Claude Code