Skip to content

ci: clear the dependency audit and follow an upstream pack rename - #613

Merged
julianknutsen merged 3 commits into
mainfrom
ci/bun-audit-advisories
Oct 24, 2026
Merged

julianknutsen merged 3 commits into
mainfrom
ci/bun-audit-advisories

Conversation

@julianknutsen

@julianknutsen julianknutsen commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Unblocks verify on main. It currently fails at Dependency audit, so typecheck, the unit and Postgres lanes, image smoke and e2e never run. Behind the audit there is a second blocker: the browser e2e web server regenerates the aggregate, and that fails on an upstream pack rename.

1. Dependency audit (dec071f)

Advisory Range Fix
smol-toml GHSA-r4xh-jqrq-34v2 <=1.8.0 direct ^1.7.1 → ^1.9.1
vite GHSA-9jrq-w75r-8gcw, GHSA-rq7h-c2jc-7f22, plus the bundled launch-editor advisories >=8.0.0 <=8.1.5 (also 8.2.0–8.2.3, 8.3.0–8.3.2) direct (dev) ^8.0.16 → ^8.3.3 (resolves 8.3.5)
brace-expansion GHSA-qhr7-859c-m2p7, GHSA-6j4f-fj2g-mc7p, GHSA-q2hr-2g5m-vwhr 2.x patched in 2.1.5 / 2.1.6 / 2.1.7 existing override >=5.0.9 → ^2.1.7. The only consumer, minimatch 5.x via @redocly/openapi-core, declares ^2.0.1; a 5.x override breaks it (expand is not a function).
source-map-js GHSA-68fv-2mgg-jv7q (via postcss) <1.2.2 new override ^1.2.2

The postcss override floor is raised to ^8.5.30, the range vite 8.3.x declares (resolves 8.5.31).

The lockfile churn is minimal. Every advisory has a patched release, so nothing needed an ignore. This follows the approach of #605.

2. Upstream pack rename (811c94e)

gascity-packs renamed contributing to contributing-to-gascity (release 0.5.0, "First release under the new name"). The expected_packs trust list in sources.toml still names the old pack, so bun run generate refuses the source with unexpected pack "contributing-to-gascity" is not declared in expected_packs. That breaks:

  • the Playwright web server, which runs bun run generate before starting;
  • the hourly aggregate refresh.

This commit renames the trust-list entry and regenerates the committed outputs.

Please review:

Local verification (each verify step)

  • bun install --frozen-lockfile: OK
  • bun audit: no vulnerabilities
  • bun run generate:check: current
  • bun run typecheck: clean
  • bun run build: OK
  • bun run openapi:check: no drift
  • bun run test:unit: 453 pass (re-run on 8dfcac0 after the override fixes, along with every other step listed here)
  • Postgres lane (REGISTRY_TEST_REQUIRE_POSTGRES=1, postgres:16): 169 pass
  • bun run test:cli: 1 pass. This used a locally installed gc, not the one extracted from the production image.
  • bun run test:e2e (Playwright, chromium): 33 pass
  • Not run locally: the production image docker build smoke.

🤖 Generated with Claude Code

julianknutsen and others added 3 commits October 23, 2026 22:33
…rce-map-js)

The Dependency audit step fails on new advisories, so typecheck, tests and e2e never run:
- smol-toml <=1.8.0 (GHSA-r4xh-jqrq-34v2): ^1.7.1 -> ^1.9.1 (direct)
- vite >=8.0.0 <=8.1.5 (GHSA-9jrq-w75r-8gcw, GHSA-rq7h-c2jc-7f22 and the bundled
  launch-editor advisories): ^8.0.16 -> ^8.1.6 (direct, dev)
- brace-expansion >=4.0.0 <5.0.11 (GHSA-qhr7-859c-m2p7, GHSA-6j4f-fj2g-mc7p,
  GHSA-q2hr-2g5m-vwhr): override >=5.0.9 -> >=5.0.11
- source-map-js <1.2.2 (GHSA-68fv-2mgg-jv7q, via postcss): new override ^1.2.2

bun audit is clean; no advisory needed an ignore.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… rename

gascity-packs renamed the `contributing` pack to `contributing-to-gascity`
(release 0.5.0, "First release under the new name"). The expected_packs trust list
still named the old pack, so `bun run generate` refuses the source ("unexpected pack
... is not declared in expected_packs"). That breaks the browser e2e web server,
which regenerates the aggregate before starting, and the hourly aggregate refresh.

Rename the entry in sources.toml and regenerate the committed aggregate outputs.
The pack key changes from gascity-packs--contributing to
gascity-packs--contributing-to-gascity, following upstream.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- brace-expansion: override >=5.0.11 -> ^2.1.7. Its only consumer (minimatch 5.x via
  @redocly/openapi-core) declares ^2.0.1, and 5.x breaks it ("expand is not a
  function"). 2.1.7 is the patched 2.x release for GHSA-qhr7-859c-m2p7 (2.1.6),
  GHSA-6j4f-fj2g-mc7p (2.1.5) and GHSA-q2hr-2g5m-vwhr (2.1.7).
- postcss: override floor -> ^8.5.30, which vite 8.3.x declares.
- vite: ^8.1.6 -> ^8.3.3, so the range excludes the vulnerable 8.2.0-8.2.3 and
  8.3.0-8.3.2.

bun audit is clean.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@julianknutsen
julianknutsen merged commit 94c4b71 into main Oct 24, 2026
6 checks passed
@julianknutsen
julianknutsen deleted the ci/bun-audit-advisories branch October 24, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant