fix: migration version comparison handles semantic versioning pre-releases#780
Open
km-git007 wants to merge 1 commit intogarrytan:mainfrom
Open
fix: migration version comparison handles semantic versioning pre-releases#780km-git007 wants to merge 1 commit intogarrytan:mainfrom
km-git007 wants to merge 1 commit intogarrytan:mainfrom
Conversation
…eases Adds helper functions _base_version() and _version_lte() to the setup migration logic to reliably compare semantic versions that may include pre-release tags (e.g., 0.15.2.0-rc1). By extracting base versions before comparison, we ensure that dev builds in the same release cycle as a migration's target version are handled correctly. Simplifies the inline version comparison logic (replacing complex sort-based comparisons with clear, testable helpers) and adds documentation explaining the semantic versioning behavior. Tested with realistic migration scenarios: - Fresh install: 0.0.0.0 -> 0.15.2.1 (runs v0.15.2.0 migration) ✓ - Already migrated: stays at 0.15.2.0 (skips v0.15.2.0) ✓ - Version bump: 0.15.2.0 -> 0.15.2.1 (runs v0.15.2.1) ✓ - Dev version: 0.15.1.0 -> 0.15.2.0-rc1 (runs v0.15.2.0) ✓ - Future migration: skips v0.15.3.0 when current is 0.15.2.1 ✓ Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds helper functions _base_version() and _version_lte() to the setup migration logic to reliably compare semantic versions that may include pre-release tags (e.g., 0.15.2.0-rc1). By extracting base versions before comparison, we ensure that dev builds in the same release cycle as a migration's target version are handled correctly.
Simplifies the inline version comparison logic (replacing complex sort-based comparisons with clear, testable helpers) and adds documentation explaining the semantic versioning behavior.
Tested with realistic migration scenarios: