schema-pack: declare extract_atoms + synthesize_concepts phases on gbrain-base-v2#2294
Open
viethungvili wants to merge 1 commit into
Open
schema-pack: declare extract_atoms + synthesize_concepts phases on gbrain-base-v2#2294viethungvili wants to merge 1 commit into
viethungvili wants to merge 1 commit into
Conversation
…rain-base-v2 gbrain-base-v2 declares the `atom` and `concept` page types, but leaves `phases:` empty — so on a base-v2 brain nothing ever populates those types (extract_atoms / synthesize_concepts are gated on the active pack's `phases:` list). The only bundled packs that declare these phases (gbrain-creator / gbrain-everything) extend the older gbrain-base v1, so adopting them means leaving the v2 canonical taxonomy. This declares the two phases on base-v2 itself, making the canonical taxonomy self-consistent: the types it ships are actually produced. `phases:` is additive (the core phases always run), so this only turns on atom extraction + concept synthesis for base-v2 brains. Verified live on a base-v2 brain: extract_atoms produced real atoms from the corpus; synthesize_concepts runs clean and promotes concepts as atoms accrue. Note: a user pack that merely `extends: gbrain-base-v2` does NOT inherit v2's types (the extends type-merge appears to skip a standalone bundled parent), so an opt-in extends-pack isn't currently a clean alternative — happy to ship this as a separate opt-in `gbrain-base-v2-creator` instead if you'd rather phases stay off base-v2 by default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
devty
added a commit
to devty/gbrain
that referenced
this pull request
Jun 20, 2026
…rain-base-v2 Port of garrytan#2294 (viethungvili). Without this phases declaration, the atom and concept types shipped in base-v2 stay empty because autopilot gates extract_atoms/synthesize_concepts on the active pack's phases list. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gbrain-base-v2declares theatomandconceptpage types, but itsphases:list is empty. Sinceextract_atoms/synthesize_conceptsare gated on the active pack'sphases:, a base-v2 brain never populates those two types — the taxonomy ships the types but nothing produces them.The only bundled packs that declare these phases (
gbrain-creator/gbrain-everything)extend: gbrain-base(v1), so adopting them means leaving the v2 canonical taxonomy and re-typing the corpus.Change
Declare the two phases on
gbrain-base-v2itself (one additive block).phases:is additive — the core phases always run — so this only turns on atom extraction + concept synthesis for base-v2 brains, making the canonical taxonomy self-consistent (the types it ships get populated).Verified
On a live base-v2 brain (≈200 pages),
extract_atomsproduced real atoms from the corpus andsynthesize_conceptsran clean (promotes concepts as atoms accrue across topics/months). I did not run the repo's full test suite locally.Open question for you
A user pack that merely
extends: gbrain-base-v2does not inherit v2's types — the extends type-merge appears to skip a standalone bundled parent (base-v2 hasextends: null). So a thin opt-inextends-pack isn't currently a clean alternative, which is why this declares the phases on base-v2 directly.If you'd rather keep phases off base-v2 by default (e.g. to avoid the per-cycle LLM cost for users who only want the taxonomy), I'm happy to instead ship a separate opt-in
gbrain-base-v2-creatorpack + register it — just let me know your preference.Drafted with Claude Code; verified against a real base-v2 brain.