Fix op checkpoint JSONB binding#2292
Closed
uncfreak1255-code wants to merge 20 commits into
Closed
Conversation
…onb-regression-tests test: cover migrate source JSONB config shape
…-pr23 docs: keep release privacy guidance generic
…e-jsonb-ci-lane Add migrate source JSONB regression to Postgres E2E CI
…ricing-clean [codex] Pin DeepSeek V4 pricing and aliases
…epseek-budget-gate Add monthly Claude and DeepSeek budget gate
Author
|
Closing this one because it was opened from the fork master lineage and includes unrelated fork history. I am rebuilding the branch from upstream/master and will reopen a narrow PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recordCompletedsoop_checkpoints.completed_keysis written as a real JSONB array on Postgres, not a double-encoded scalar string.executeRawDirectand fix the admin build gate that was timing out in verify.Proof
bun run verify-> 30/30 checks greenbun test test/op-checkpoint.test.ts-> 31 pass, 0 failpgvector/pgvector:pg16E2E:DATABASE_URL=postgresql://postgres:postgres@localhost:5435/gbrain_test bun test test/e2e/op-checkpoint-jsonb-postgres.test.ts-> 1 pass, 0 failarray|chunk-a|2Notes
Compared with upstream PR #2288, this keeps the fix narrow but avoids passing a bare top-level JS array into
$3::jsonb; the value is wrapped in an object and extracted server-side with($3::jsonb)->'completed_keys'.