feat(cli): Init CLI to create arbitrary upgrade-prs#1506
feat(cli): Init CLI to create arbitrary upgrade-prs#1506
Conversation
Signed-off-by: Philipp Heil (zkdev) <philipp.heil@sap.com>
|
CLIs we have as part of our actions thus-far were crafted with the intention to test to action's code itself, and typically reuse the action. It might be considered to deviate from this pattern. However, in this case, I think it is not a good fit. Also, it mixes different aspects:
the first part is IMO not relevant for local uses: If pipeline should not be used, it is to be expected users will already have a copy of the git-repository that should receive a pullrequest. Typically, authentication is also already setup. As for the publishing-part, that can also be handled by gh-cli (making this CLI overlapping w/ GH-CLI). Hence, I would suggest to consider dropping the first and latter parts, and keep the middle one: create diff for OCM-Upgrade. However, I think this also should be split:
All of those commands can either work fully on local git-repository, or will work (authentication-wise) by reading from local user's docker-cfg. |
| f' {parsed.version_to} in {parsed.repo_url}' | ||
| ) | ||
|
|
||
| with tempfile.TemporaryDirectory() as tmpdir: |
There was a problem hiding this comment.
If this CLI is intended for local usage, I think including the code to retrieve the repository is not a good fit.
This makes the underlying operation more expensive, and at the same time makes it less convenient to use (as users have to provide an access-token).
In addition, this partially overlaps w/ gh-CLI.
|
@8R0WNI3, @TuanAnh17N You have pull request review open invite, please check |
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
Not sure about the standalone CLI.
We might offer a cicd-cli v2 without Concourse dependencies via a lightweight python distribution package on PyPi.
Open for suggestions here 🙂
Release note: