Show name and avatar for bot messages#77
Merged
Conversation
Owner
|
Reviewed in a worktree — build passes, Well-targeted fix: correct root cause (bot_message has empty Nits (non-blocking):
|
Contributor
Author
|
Thanks for the review! Addressed the nits in f387eb9 (non-functional, comments + wording only):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76.
Problem
Bot/app messages (
bot_message) carry nouser— onlybot_id,username, and sometimesicons. The conversion read onlym.User, so bot messages gotUserID == "": the avatar lookup missed and the author name was dropped. This hit every bot, since even apps with a bot user post asbot_messagewith an emptyuser.Fix
bot_idand use the message'susername, in all three fetch paths (newmessageAuthorhelper) and the live WebSocket path (OnMessagenow receivesbot_id/username, threaded through the event struct + dispatch).userResolver.RequestBotresolves the icon viabots.infoonce per bot (deduped, persisted) and preloads it viaavatars.Preload(bot_id, …);AvatarURLs[bot_id]is then populated on the resolve/connect path — mirroring theusers.infopath for humans. AddedGetBotInfoto the client.UserID == ""before this change are re-keyed by parsingbot_id/usernameout ofraw_jsoninenrichCachedRow, so existing cached bot messages render without a cache wipe.Testing
go test ./...passes. AddedTestMessageAuthorBotIdentity(fetch-path identity) and extendedTestDispatchWebSocketBotMessageEventto assertbot_id/usernameflow through the WS dispatch.