Restore the last-visited channel on startup#72
Merged
Conversation
ab192fd to
5586a0e
Compare
Owner
|
One trivial fix: |
Contributor
Author
|
Fixed in 03980a4 — added the blank line between |
Owner
|
🍔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On startup, the active workspace now opens the most-recently-visited channel instead of always snapping to the sidebar's first entry — so a restart lands you back where you left off.
How
The
channel_visitstable already persists a per-channellast_visitedtimestamp (and is loaded intoWorkspaceContext.LastVisitedByChannelat connect). This wires that existing data into the startup path:mostRecentlyVisitedChannel(visits)picks the channel with the latest timestamp; it's passed onWorkspaceReadyMsg.LastChannelID.reduceWorkspaceReady(theInitialActivebranch) opensLastChannelIDwhen it's set and still present in the sidebar, otherwise falls back toChannels[0].Only the startup path changed; the existing mid-session workspace-switch restore (
lastChannelByTeam) is untouched.Edge cases
LastChannelIDis empty → opensChannels[0](unchanged behavior).Channels[0].Testing
go test ./...passes; addedTestWorkspaceReadyRestoresLastChannelcovering restore, the empty-visit fallback, and the stale-channel fallback.