Unit test naming#2193
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the unit-test discipline in simtools by adding a CI workflow check that enforces a 1:1 mapping between Python modules under src/simtools (excluding __init__.py and applications/) and corresponding unit test files under tests/unit_tests/.
Changes:
- Add a CI step to fail if any
src/simtools/**/*.pymodule lacks a matchingtests/unit_tests/**/test_<module>.py. - Add a new unit test module for
production_configuration/calculate_statistical_uncertainties_grid_point.py. - Add a changelog fragment documenting the CI enforcement.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/unit_tests/production_configuration/test_calculate_statistical_uncertainties_grid_point.py |
Adds unit tests for statistical uncertainty evaluation/production statistics logic. |
docs/changes/2193.maintenance.md |
Documents the new CI enforcement in the changelog. |
.github/workflows/CI-unittests.yml |
Adds a pre-test CI gate that checks module↔test-file presence. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
GernotMaier
added
the
no-changelog-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new check to the continuous integration (CI) workflow to ensure better test coverage by verifying that every Python module in
src/simtools(except for__init__.pyand files underapplications) has a corresponding unit test file.(trigger by finding a file with a naming mismatch)