Separate production grid generation from HT Condor backend. Allow nshow to follow powerlaw.#2188
Open
GernotMaier wants to merge 11 commits into
Open
Separate production grid generation from HT Condor backend. Allow nshow to follow powerlaw.#2188GernotMaier wants to merge 11 commits into
GernotMaier wants to merge 11 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors production job grid construction into a backend-facing builder module and adds energy-dependent nshow scaling for simulation production generation.
Changes:
- Adds
job_spec_builderfor generating job specs and resolving grid axes. - Adds
nshow_power_indexandnshow_reference_energysupport. - Updates HTCondor generation/tests/docs/changelog and adds a unit-testing Copilot skill.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/simtools/production_configuration/job_spec_builder.py |
New production job spec builder and nshow scaling helpers. |
src/simtools/job_execution/htcondor_script_generator.py |
Uses the new builder and adapts job-spec label fields. |
src/simtools/applications/simulate_prod_htcondor_generator.py |
Adds CLI arguments for power-law nshow scaling. |
tests/unit_tests/production_configuration/test_job_spec_builder.py |
Adds unit tests for the new builder module. |
tests/unit_tests/job_execution/test_htcondor_script_generator.py |
Updates HTCondor tests for the refactor and multi-label files. |
tests/unit_tests/applications/test_simulate_prod_htcondor_generator.py |
Tests registration of new CLI options. |
docs/source/api-reference/production_configuration.md |
Adds API reference entry for job_spec_builder. |
docs/changes/2188.feature.md |
Adds feature changelog fragment. |
docs/changes/2187.maintenance.md |
Adds maintenance changelog fragment. |
.github/skills/unit-testing/SKILL.md |
Adds Copilot unit-testing skill guidance. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Two updates to
simulate_prod_htcondor_generator.pyand the possibility of defining a full Grid of simulations configurations:Functional
Allow
NSHOWto follow a pre-defined power law (until now, the number of simulated showers was the same for all energies).Example:
Will give you 1000 showers at 3 TeV, 100000 at 30 GeV and 10000 300 GeV.
Maintenance
Separate grid generation from the HTCondor module to make sure it can be used with other backends in futures (new module
job_spec_builder.py).