Maintenance update for image building#2153
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Maintenance updates to the container build stack (CORSIKA, sim_telarray, simtools dev/prod images) to support newer AlmaLinux bases and remove legacy build paths, including adding a GSL-from-source workflow for sim_telarray.
Changes:
- Bump AlmaLinux base images from 9.5 to 9.7 via a shared build-arg.
- Build and ship GSL from source in the sim_telarray image and propagate the runtime libs into simtools images.
- Remove legacy Dockerfiles and legacy GitHub Actions workflows; extend the sim_telarray workflow to fetch the GSL source tarball.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/Dockerfile-simtools-prod | AlmaLinux version parametrized; copies GSL libs from sim_telarray; adjusts env vars |
| docker/Dockerfile-simtools-dev | AlmaLinux version parametrized; copies GSL libs; base-image selection changed |
| docker/Dockerfile-simtel_array | AlmaLinux version parametrized; adds GSL source build and copies libs into runtime image |
| docker/Dockerfile-corsika7 | AlmaLinux version parametrized; minor cleanup/comment tweak |
| docker/Dockerfile-simtools-legacy | Removed legacy simtools build Dockerfile |
| docker/Dockerfile-corsika-simtel | Removed legacy combined CORSIKA/sim_telarray Dockerfile |
| .github/workflows/build-sim_telarray.yml | Adds an artifact step to provide gsl.tar.gz to the Docker build context |
| .github/workflows/build-simtools-legacy.yml | Removed legacy simtools image workflow |
| .github/workflows/build-corsika-simtel-legacy.yml | Removed legacy base-image workflow |
|
orelgueta
approved these changes
May 6, 2026
Contributor
Author
|
Thanks @orelgueta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance update for image building - mostly to simplify future updates for newer alma linux base images:
This should make it easier to move towards updates of almalinux (e.g. with newer python versions).