Issue 219 no2#240
Open
pdeiml wants to merge 3 commits into
Open
Conversation
Contributor
|
I would stronly prefer to only have one single config file for the catalog. |
Collaborator
Author
|
Ok, if we stay with one single file, then I would suggest to add three additional infos: What do you think? |
Contributor
|
I would leave But either way, your more verbose, but also more explicit choice for each part of the catalog data is also good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one way how to control which SED goes to the catalog.
If you look to input/gammacat/gamma_cat_sed.yaml and there at source_id = 1, you can see the idea:
- reference_id: The reference_id of the sed which goes to the catalog
- file_id: If there are more than one sed file, the file with file_id goes to the catalog (if there is only one file, the default value is -1)
I only want to introduce this idea of a schema and if it is agreed then one needs to add the keywords to all sources.