Use CSS aspect-ratio for YouTube Shorts video embeds#32
Open
galexy wants to merge 1 commit into
Open
Conversation
…ttom The padding-bottom percentage trick doesn't work with max-width because padding-bottom % is calculated relative to the containing block's width, not the element's own width. This caused the Shorts container to have wildly incorrect dimensions. Using aspect-ratio: 9/16 correctly maintains the vertical aspect ratio regardless of the element's constrained width. https://claude.ai/code/session_01H78kWkQ4THsAS4jkRRrbkH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the YouTube Shorts video embed styling to use the modern CSS
aspect-ratioproperty instead of the padding-bottom hack for maintaining a 9:16 aspect ratio.Key Changes
padding-bottom: 177.78%with theaspect-ratio: 9 / 16CSS propertypadding-bottom: 0to remove the previous aspect ratio calculation methodmax-width: 360pxconstraint for responsive sizingImplementation Details
This change modernizes the aspect ratio handling for vertical video embeds by leveraging native CSS support for
aspect-ratio, which is now widely supported across modern browsers. This approach is cleaner and more maintainable than the traditional padding-bottom percentage hack, while achieving the same visual result with better performance and readability.https://claude.ai/code/session_01H78kWkQ4THsAS4jkRRrbkH