Treat normal and secure built-in namespaces as existing namespaces - #703
Open
eamansour wants to merge 1 commit into
Open
Treat normal and secure built-in namespaces as existing namespaces#703eamansour wants to merge 1 commit into
eamansour wants to merge 1 commit into
Conversation
…es instead of returning not found Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Refer to galasa-dev/projectmanagement#2631
This PR adds the
servicenamespace as a built-in namespace.Previously, all existing namespaces and non-existent namespaces would be initialised as
CPSNamespaceobjects. The API server would then check if a namespace contained any properties to determine whether it actually exists. This meant that if a built-in namespace likesecureorservicedidn't contain properties, then it would be treated as a non-existent namespace and return a 404 Not Found.This PR fixes this by treating built-in namespaces as namespaces that always exist, regardless of whether they contain properties, so the API server will not return a 404 Not Found.
Changes
serviceto the built-in namespaces