Simplify text reconstruction - #21
Merged
Merged
Conversation
Replace manual text reconstruction with the built-in FullText property which already includes leading and trailing trivia. Remove unnecessary ReconstructText and AppendNodeText helper methods.
Blender no longer needs to implement ICharacterSource directly since BlenderCharacterSource already wraps the character access methods. Pass _characterSource directly to Lexer instead of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Replace manual text reconstruction with
ProgramSyntax.FullTextand makeBlenderstop implementingICharacterSource, routing lexing through an internal character-source wrapper.program.FullTextinExecute(ProgramSyntax); remove custom text reconstruction helpers and relatedSystem.Textusage.Blenderno longer implementsICharacterSource; remove delegated interface members.Lexernow constructed with_characterSourceinstead ofthis.BlenderCharacterSource, keeping position tracking methods (PeekCharacterCore,ConsumeCharacterCore) internal.Written by Cursor Bugbot for commit 3f8847a. This will update automatically on new commits. Configure here.