plugin: expand python-skills workflows#53
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR expands the python-skills plugin with seven new skill workflows, refactors its validator to require AGENTS.md guidance, updates architecture/manifest/catalog documentation (including marketplace category), and synchronizes version 6.10.0 across the root package and plugin manifests. ChangesPython Skills Plugin Expansion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/architecture/architecture.json`:
- Line 501: The projectRoot field currently contains a machine-local absolute
path; replace the value of the "projectRoot" key in
docs/architecture/architecture.json with a repository-relative path (for example
"." or the repo subpath like "socket-wt-python-skills-gap-analysis") so the file
no longer contains workstation-specific absolute paths; also update any code
that generates this JSON to emit a repo-relative value instead of an absolute
filesystem path.
In `@plugins/python-skills/skills/choose-python-project-shape/agents/openai.yaml`:
- Line 3: The short_description value contains the term "package" twice; update
the short_description key to remove the duplicated word so the sentence reads
cleanly (e.g., "Choose Python package, service, MCP, workspace, test, tooling,
CI, or upgrade shape.") — edit the short_description string in the YAML
(short_description) to remove the duplicate and ensure punctuation/commas remain
correct.
In `@plugins/python-skills/skills/python-upgrade-workflow/agents/openai.yaml`:
- Line 5: The agent default prompt (the default_prompt value) is missing the
SKILL guardrail that forbids publishing/creating releases unless explicitly
requested; update the default_prompt string to mirror the SKILL.md constraint
exactly by appending a clear instruction such as “do not publish or create
releases unless explicitly requested” (or the exact wording used in SKILL.md) so
the agents/openai.yaml default_prompt and the SKILL.md contract remain
consistent.
In `@plugins/python-skills/skills/python-upgrade-workflow/SKILL.md`:
- Around line 45-49: The grep inventory step currently hard-codes optional paths
(the first rg that searches "requires-python|dependencies|..." and the second rg
--files -g list) which can fail if docs/README.md/.github are absent; update
SKILL.md so the first rg runs repository-wide (remove explicit optional paths
from the file list) or gate those paths with existence checks, or change the
second command to glob only required files (e.g., keep -g 'pyproject.toml' -g
'uv.lock' -g '.python-version' -g '.github/workflows/*.yml' -g
'.github/workflows/*.yaml') and omit docs/README.md, ensuring the workflow step
won’t error when optional paths are missing.
In `@README.md`:
- Line 81: The `python-skills` catalog bullet is too implementation-heavy;
replace its long technical list with a brief, user-facing installation/usage
line for `python-skills` (e.g., "Python runtime and tooling for running
Python-based skills; see docs for setup"), and add a link to a deeper docs page
for development details (point readers to a dedicated docs/CONTRIBUTING or
workflow page) so the root README stays short and nontechnical.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5acd802d-75a3-47b3-864a-234ca6f2daef
⛔ Files ignored due to path filters (8)
plugins/agent-plugin-skills/uv.lockis excluded by!**/*.lockplugins/apple-dev-skills/uv.lockis excluded by!**/*.lockplugins/cardhop-app/mcp/uv.lockis excluded by!**/*.lockplugins/productivity-skills/uv.lockis excluded by!**/*.lockplugins/python-skills/uv.lockis excluded by!**/*.lockplugins/things-app/mcp/uv.lockis excluded by!**/*.lockplugins/things-app/uv.lockis excluded by!**/*.lockuv.lockis excluded by!**/*.lock
📒 Files selected for processing (42)
.agents/plugins/marketplace.jsonREADME.mdROADMAP.mdTODO.mddocs/architecture/ARCHITECTURE.mddocs/architecture/architecture.jsondocs/maintainers/python-skills-plugin-plan.mdplugins/agent-plugin-skills/.codex-plugin/plugin.jsonplugins/agent-plugin-skills/pyproject.tomlplugins/apple-dev-skills/.codex-plugin/plugin.jsonplugins/apple-dev-skills/pyproject.tomlplugins/cardhop-app/.codex-plugin/plugin.jsonplugins/cardhop-app/mcp/pyproject.tomlplugins/dotnet-skills/.codex-plugin/plugin.jsonplugins/productivity-skills/.codex-plugin/plugin.jsonplugins/productivity-skills/pyproject.tomlplugins/python-skills/.codex-plugin/plugin.jsonplugins/python-skills/pyproject.tomlplugins/python-skills/scripts/validate_repo_metadata.pyplugins/python-skills/skills/build-python-project/SKILL.mdplugins/python-skills/skills/build-python-project/agents/openai.yamlplugins/python-skills/skills/choose-python-project-shape/SKILL.mdplugins/python-skills/skills/choose-python-project-shape/agents/openai.yamlplugins/python-skills/skills/diagnose-python-project/SKILL.mdplugins/python-skills/skills/diagnose-python-project/agents/openai.yamlplugins/python-skills/skills/python-ci-workflow/SKILL.mdplugins/python-skills/skills/python-ci-workflow/agents/openai.yamlplugins/python-skills/skills/python-package-workflow/SKILL.mdplugins/python-skills/skills/python-package-workflow/agents/openai.yamlplugins/python-skills/skills/python-tooling-style-workflow/SKILL.mdplugins/python-skills/skills/python-tooling-style-workflow/agents/openai.yamlplugins/python-skills/skills/python-upgrade-workflow/SKILL.mdplugins/python-skills/skills/python-upgrade-workflow/agents/openai.yamlplugins/python-skills/tests/test_plugin_smoke.pyplugins/rust-skills/.codex-plugin/plugin.jsonplugins/spotify/.codex-plugin/plugin.jsonplugins/swiftasb-skills/.codex-plugin/plugin.jsonplugins/things-app/.codex-plugin/plugin.jsonplugins/things-app/mcp/pyproject.tomlplugins/things-app/pyproject.tomlplugins/web-dev-skills/.codex-plugin/plugin.jsonpyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Summary by CodeRabbit
New Features
Chores
Documentation
Tests