fix: three high-severity bugs in CSV export and response parsing#46
Open
gacolitti wants to merge 2 commits into
Open
fix: three high-severity bugs in CSV export and response parsing#46gacolitti wants to merge 2 commits into
gacolitti wants to merge 2 commits into
Conversation
- dk_write_csv.showdown_captain_mode_multiple_solutions: iterate over all lineups instead of only the first (optimal_lineups[1] -> optimal_lineups) - Add missing dk_write_csv.classic_multiple_solutions S3 method so classic lineups can be exported to CSV for upload - Fix exists() scoping bug in dk_resp_parse.draft_group_info_resp by initializing sport_specific_data to NULL and using is.null() check instead of exists() which defaults to global environment scope https://claude.ai/code/session_0125BTXN7vF67ToLxTXeKX1i
…thod Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> https://claude.ai/code/session_0125BTXN7vF67ToLxTXeKX1i
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all lineups instead of only the first (optimal_lineups[1] -> optimal_lineups)
classic lineups can be exported to CSV for upload
initializing sport_specific_data to NULL and using is.null() check
instead of exists() which defaults to global environment scope
https://claude.ai/code/session_0125BTXN7vF67ToLxTXeKX1i