Skip to content

[remove] ecdhCurve option from tls.connect for https links#24

Open
DELUUXE wants to merge 1 commit intogabek:masterfrom
DELUUXE:master
Open

[remove] ecdhCurve option from tls.connect for https links#24
DELUUXE wants to merge 1 commit intogabek:masterfrom
DELUUXE:master

Conversation

@DELUUXE
Copy link
Copy Markdown

@DELUUXE DELUUXE commented Apr 12, 2021

Fixes The "options.ecdhCurve" property must be of type string. Received type boolean (false) when using https urls

May solve issue #21

Node version: v15.7.0
Radio tested: icecast (azuracast)

Fixes: The "options.ecdhCurve" property must be of type string. Received type boolean (false)
@meinaart
Copy link
Copy Markdown

Can this please be merged? Its a blocker for using this for my project.

@gabek
Copy link
Copy Markdown
Owner

gabek commented Aug 29, 2023

Hi there. Admittedly I haven't had a use for this library lately. I've moved to writing everything in Go 😃

I'd be happy to merge this in and publish a new version, but maybe there should be a longer term plan. I didn't realize this was being actively used.

Happy to hear any thoughts!

@meinaart
Copy link
Copy Markdown

Hi @gabek, I think this library works great as it is. The ecdhCurve property is just not compatible with the latest node versions. I think thats actually the only change needed to make it compatible with latest node.

If you do have some additional time; making the loglevel configurable would be nice. It now has some console.trace statements that can't be disabled. Which is polluting the stdout when you are retrieving a bunch of streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants