Bump google.golang.org/grpc from 1.31.0 to 1.79.3 in /prometheus-to-sd#2
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.0 to 1.79.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.31.0...v1.79.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 600d012. Configure here.
| conf.MaxDecoderHeaderTableSize = uint32(h2.MaxDecoderHeaderTableSize) | ||
| } | ||
| if h2.MaxConcurrentStreams != 0 { | ||
| conf.MaxConcurrentStreams = uint32(h2.MaxConcurrentStreams) |
There was a problem hiding this comment.
Duplicate MaxConcurrentStreams assignment in config function
Low Severity
In fillNetHTTPConfig, the h2.MaxConcurrentStreams check and assignment to conf.MaxConcurrentStreams appears twice — at lines 130–131 and again at lines 142–143. The second occurrence is an exact duplicate of the first and has no effect. This is a copy-paste redundancy in the vendored upstream golang.org/x/net/http2 code.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 600d012. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps google.golang.org/grpc from 1.31.0 to 1.79.3.
Release notes
Sourced from google.golang.org/grpc's releases.
... (truncated)
Commits
dda86dbChange version to 1.79.3 (#8983)72186f1grpc: enforce strict path checking for incoming requests on the server (#8981)97ca352Changing version to 1.79.3-dev (#8954)8902ab6Change the version to release 1.79.2 (#8947)a928670Cherry-pick #8874 to v1.79.x (#8904)06df363Change version to 1.79.2-dev (#8903)782f2deChange version to 1.79.1 (#8902)850eccbChange version to 1.79.1-dev (#8851)765ff05Change version to 1.79.0 (#8850)68804beCherry pick #8864 to v1.79.x (#8896)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Note
Medium Risk
Large dependency and vendored code refresh (including
google.golang.org/grpcandgolang.org/x/net/http2) plus a Go toolchain version bump could introduce behavioral or compatibility changes at runtime despite no direct app code changes.Overview
Updates
prometheus-to-sdto Go 1.24 and bumps key dependencies, notablygoogle.golang.org/grpctov1.79.3alongside newergolang.org/x/*libraries and related transitive modules.Refreshes the
vendor/tree accordingly, pulling in substantial upstream changes (e.g.,x/netHTTP/2 updates,gloglogging/rotation and file-creation hardening,logrAPI/context additions, andxxhashupdates including new arm64 asm support).Reviewed by Cursor Bugbot for commit 600d012. Bugbot is set up for automated code reviews on this repo. Configure here.