fix: add units to result summary output#118
Open
hashwnath wants to merge 2 commits into
Open
Conversation
Appends "(ms)" to all time-based metric labels in the summary output so users can immediately see the unit. This covers both the base metrics (e.g. "Total Latency (ms)") and their percentile variants (e.g. "P99 Total Latency (ms)"). Closes fw-ai#5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit bcbbce5. Configure here.
P99.9_ metrics were matching the P99_ prefix first, causing the (ms) suffix to be silently dropped for P99.9 percentile time metrics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
(ms)to all time-based metric labels in the summary output, so users can immediately tell what unit each value usesTime To First Token,Latency Per Token,Overall Latency Per Token,Total Latency,Latency Per Embedding,Latency Per Char) and their percentile variants (P50,P90,P95,P99,P99.9)Closes #5
Before
After
Test plan
--streamand verify summary labels show(ms)for time-based metrics--embeddingsand verifyLatency Per Embedding (ms)appearsNum Tokens,Qps,Prompt Tokens) do not get a unit suffix🤖 Generated with Claude Code
Note
Low Risk
Display-only label formatting in the quit summary and optional CSV export; no change to measured values or request behavior.
Overview
Load test summary output (console and
--summary-fileCSV column headers) now appends(ms)to labels for time-based metrics.The one-line
pretty_namelambda is replaced with logic that maps known latency metrics (time_to_first_token,latency_per_token,overall_latency_per_token,total_latency,latency_per_embedding,latency_per_char) and their percentile variants (e.g.P50_total_latency) by stripping theP50_/P90_/ etc. prefix before deciding whether to add the unit suffix. Count/rate fields like QPS and token counts are unchanged.Reviewed by Cursor Bugbot for commit aee9790. Bugbot is set up for automated code reviews on this repo. Configure here.