-
Notifications
You must be signed in to change notification settings - Fork 38
llm_bench: add --targets for multi-deployment load testing #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aidando73
wants to merge
5
commits into
main
Choose a base branch
from
aidand-multi-target-load-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2dc7362
llm_bench: add --targets for sending traffic to multiple deployments
aidando73 bd1a2e8
llm_bench: interpret -u/--users as per-target with --targets
aidando73 3d61e81
llm_bench: tighten --targets help text
aidando73 993516d
llm_bench: skip model comparison in notify_init when --targets is set
aidando73 5ff4c81
llm_bench: use deployment id as target label when targets share a URL
aidando73 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request stat names change even without --targets flag
Medium Severity
The
nameparameter is unconditionally applied to the request, changing locust stats row names from the bare path (e.g./v1/chat/completions) to[https://host] /v1/chat/completionseven when--targetsis not used. The PR promises backward-compatibility when--targetsis unset, but this always-on label prefix breaks existing dashboards, scripts, or--max-fail-ratiomonitoring that matches stats by request name.Additional Locations (1)
llm_bench/load_test.py#L1175-L1182Reviewed by Cursor Bugbot for commit 2dc7362. Configure here.